Skip to content

Properly deal with acquired status

Pier-Luc Gagnon requested to merge pier-luc.gagnon/gitlab-runner:bugfix/better-idle-machine-handling into master

This is a recreation of !1624 (closed) since it was stale

What does this MR do?

This merge request fixes #2251 (closed) by ensuring that idle machines are not left in the acquired status forever. That ensures that using IdleCount: 1 in the gitlab-runner configuration will not cause tons of No free machines that can process builds in the logs.

It also ensures that users do not see the No free machines error if gitlab-runner is creating a new machine to run the job.

Finally, it adds all of the machineDetails() fields to the debug log to make bugs like these easier to find in the future.

Why was this MR needed?

We have a good use case for IdleCount: 1 via docker machine in AWS and the No free machines messages were filling our logs.

Are there points in the code the reviewer needs to double check?

Nothing special other than a normal review.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#2251 (closed) #3437

Merge request reports