Skip to content

Fix broken test output produced by MakeFatalToPanic

Arran Walker requested to merge 27921-fix-broken-test-output into master

What does this MR do?

Updates MakeFatalToPanic to use Fprintln. ensuring that a newline character appears in the output (similar to the output in non-test environments).

Why was this MR needed?

Use of this function is breaking test output parsing. By not adding a newline, output appears as:

invalid argument=== RUN   TestArtifactsDownloader/fastzip#02

Rather than:

invalid argument
=== RUN   TestArtifactsDownloader/fastzip#02

Go's own test2json and the test to junit project we use cannot parse these tests correctly and they don't get adding to our junit report.

What's the best way to test this MR?

Compare test output to from a previous pipeline to this pipeline.

What are the relevant issue numbers?

Closes #27921 (closed)

Merge request reports