Skip to content

Move Kubernetes integration tests to separate file

Pedro Pombeiro requested to merge pedropombeiro/27608/kubernetes-executor into master

What does this MR do?

It segregates the integration tests from the kubernetes package into a different file (so it can be easily tagged later) and package (so we know that it doesn't leverage internal aspects of the tested package).

Some tests are hard to fix within the scope of this MR. Take for instance TestSetupCredentials: it uses internal aspects of the executor, so it looks like a unit test, but on the other hand interacts and is affected by the filesystem, so it looks more like an integration test.

Why was this MR needed?

Integration tests are currently mingled with unit tests, making it difficult to know where to add a new integration test, or for example to run only unit tests ignoring integration tests.

What's the best way to test this MR?

Check that moved tests still execute in the integration_k8s and unit test 4/8 CI jobs, e.g.:

What are the relevant issue numbers?

#27608 (closed)

Edited by Pedro Pombeiro

Merge request reports