Skip to content

Correctly set fastzip's staging directory

Arran Walker requested to merge 27462-fastzip-fails-to-archive-cache-due-to-temp-path-collision into master

What does this MR do?

Correctly sets fastzip's staging directory

Why was this MR needed?

Fastzip uses a temporary staging directory to achieve concurrent zip archiving. This was accidentally set to be the main temporary directory, rather than a subdirectory within.

The result is that the temporary files get clobbered if runner is running concurrently on the same system, with them all trying to access the same temporary directory.

What's the best way to test this MR?

It's a little difficult to test. With the directory now being different, files won't be clobbered.

go test ./commands/...

Will run our existing tests for the archivers to ensure that things, under normal circumstances, still function.

What are the relevant issue numbers?

Closes #27462 (closed)

Edited by Arran Walker

Merge request reports