Skip to content

Clarify how service_account in toml is used

Ben Bodenmiller requested to merge patch-4 into master

What does this MR do?

Per https://gitlab.com/gitlab-org/gitlab-runner/-/blob/master/common/config.go#L259. Also supported by https://gitlab.com/gitlab-org/gitlab-runner/-/blob/master/executors/kubernetes/kubernetes.go#L968 and https://gitlab.com/gitlab-org/gitlab-runner/-/blob/master/executors/kubernetes/overwrites.go#L142 as well as supporting test at https://gitlab.com/gitlab-org/gitlab-runner/-/blob/master/executors/kubernetes/kubernetes_test.go#L1278

Related issues

Author's checklist (required)

When applicable:

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Ben Bodenmiller

Merge request reports