Skip to content

Detach runtime state/metric from CI_JOB_STATUS

Arran Walkerrequested to merge
27068-metrics-specify-that-a-job-has-failed-succeeded-even-when-running-after_script-which-breaks into master

What does this MR do?

Detaches the runtime state, that we also use for metrics, from the CI_JOB_STATUS we set to let after_script know if the previous stages were a success or failure.

Why was this MR needed?

Having CI_JOB_STATUS be equal to the runtime state meant that the newly introduced after_script even on failure behaviour would report via metrics that the job was no longer running, but instead completed.

What's the best way to test this MR?

TestBuildJobStatusEnvVars remains unchanged.

What are the relevant issue numbers?

Closes #27068 (closed)

Merge request reports