Skip to content

Re-enable windows docker tests

What does this MR do?

Re-enable windows docker tests and increase the timeout for tests on Windows from default 10 minutes to 30 minutes, so that Docker has enough time to fetch the gitlab-runner-helper image and Windows 1809 layer.

Why was this MR needed?

Some of tests where marked to be skipped in !2212 (merged) by mistake. We should still keep running these tests since they run successfully on Windows and should not ignore them.

Add some of the known failures back to ci/.test-failures.servercore1809.txt even though they are skipped that file should be our SSOT of which tests we should fix in the future, so we shouldn't delete the tests even if they are being skipped.

What's the best way to test this MR?

# On a windows machines
go test -v -run "TestDockerCommandSuccessRun|TestDockerCommandMultistepBuild|TestDockerCommandSuccessRunRawVariable|TestDockerCommandUsingCustomClonePath|TestDockerCommandBuildFail" gitlab.com/gitlab-org/gitlab-runner/executors/docker

What are the relevant issue numbers?

closes #26622 (closed)

Merge request reports

Loading