Revert to the old gitlab-runner install path
What does this MR do?
Revert to the old gitlab-runner install path. The path now is back to /usr/lib/gitlab-runner/gitlab-runner
instead of /usr/bin/gitlab-runner
Why was this MR needed?
This reverts commit a0d2f809, reversing changes made to e1cb6972.
This commit changes to the Runner installed location from
/usr/lib/gitlab-runner/gitlab-runner
to /usr/bin/gitlab-runner
which
can cause breaking changes to deploy scripts and anything the user has
to manage gitlab-runner
binary.
Revert this merge request to be included in 13.2.0-rc2
and then in
13.3 implement the same fix as
#26582 (closed) but have
/usr/lib/gitlab-runner/gitlab-runner
be a symlink so it doesn't break
users scripts.
What's the best way to test this MR?
# Build runner binary
make runner-bin BUILD_PLATFORMS="-osarch='linux/amd64'"
# Package
make package-deb-arch ARCH=amd64 PACKAGE_ARCH=amd64 RUNNER_BINARY=out/binaries/gitlab-runner-linux-amd64
# Start docker shell
docker run --rm -it -v $PWD:/code -w /code ubuntu:20.04
# Install with dpkg
dpkg -i out/deb/gitlab-runner_amd64.deb
# Check where `gitlab-runner` was installed. It should be `/usr/bin/gitlab-runner`
which gitlab-runner
/usr/bin/gitlab-runner
# Check that `/usr/bin/gitlab-runner` is a symlink to `/usr/lib/gitlab-runner/gitlab-runner`
ls -la /usr/bin/gitlab-runner
lrwxrwxrwx 1 root root 34 Jul 13 12:05 /usr/bin/gitlab-runner -> ../lib/gitlab-runner/gitlab-runner
What are the relevant issue numbers?
Closes #26582 (closed)