Skip to content

Fix data race in TestNewReadLogsCommandFileLogStreamProviderCorrect

Georgi N. Georgiev requested to merge fix_data_race_TestNewReadLogsCommandFileLogStreamProviderCorrect into master

What does this MR do?

Fixes data race in TestNewReadLogsCommandFileLogStreamProviderCorrect.

Why was this MR needed?

Are there points in the code the reviewer needs to double check?

We need to check if a file exists so that readLogs can exit if we delete it, which provides a nice cancellation mechanism which allows us to fix the race. As a nice side effect, if the log file in production cases get deleted, the process will exit with the correct error message, otherwise, it would just hang.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Closes #26028 (closed)

Merge request reports