Fix flaky TestListenReadLines in log processor (!2191) · Merge requests · GitLab.org / gitlab-runner · GitLab

Georgi N. Georgiev requested to merge fix_flaky_TestListenReadLines into master Jun 06, 2020

What does this MR do?

Fixes flaky TestListenReadLines test.

Example failure: https://gitlab.com/gitlab-org/gitlab-runner/-/jobs/584312624#L1775.

Changed other tests that were susceptible to the same failure.

To reproduce the failure I needed around 250 runs.

After the changes 500 runs of the whole suite didn't show any failures.

Why was this MR needed?

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

Documentation created/updated
Added tests for this feature/bug
In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

closes #26037 (closed)

Edited Jun 09, 2020 by Steve Xuereb