Skip to content

Allow HTTP/2

Viktar Vauchkevich requested to merge victorenator/gitlab-runner:allow-http2 into main

What does this MR do?

Enables HTTP/2 connections.

Why was this MR needed?

HTTP/2 is disabled by default, and requires forcing, because a custom Dial func and TLSClientConfig are being set.

Are there points in the code the reviewer needs to double check?

Additional context for why forcing is required: https://github.com/golang/go/issues/14275

Where this is handled in Go: https://github.com/golang/go/blob/master/src/net/http/transport.go#L369

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Edited by 🤖 GitLab Bot 🤖

Merge request reports