Do not log warning if trace update interval header value is empty (!2103) · Merge requests · GitLab.org / gitlab-runner · GitLab

As of 2024-05-14 a change has been implemented to enforce access token expiry. If you see higher numbers of HTTP 401 responses, please check tokens that may have expired. For more details, including how to mitigate disruption, please check our docs guide on Expired Access Tokens. If you have a support contract, you may open a support ticket for additional assistance.

You need to sign in or sign up before continuing.

Pedro Pombeiro requested to merge remove-trace into master May 15, 2020

What does this MR do?

It prevents logging a normal situation as a warning.

Why was this MR needed?

I saw this warning in the log, but this is a benign situation:

WARNING: Failed to parse "X-GitLab-Trace-Update-Interval" header  error=strconv.Atoi: parsing "": invalid syntax header-value= job=737 runner=pYJpZ6jY

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

Documentation created/updated
Added tests for this feature/bug
In case of conflicts with master - branch was rebased

What are the relevant issue numbers?