Skip to content

Refactor tests in builds_helper_test

Arran Walker requested to merge ajwalker/gitlab-runner:build-helpers-refactor into master

What does this MR do?

In builds_helper_test.go:

  • Changes ListJobsHandler to use an anonymous struct.
  • Populates the test case more cleanly.
  • Uses the built-in httptest.ResponseRecorder for recording the results of a HTTP request to the list jobs handler.

Why was this MR needed?

#24987 (closed)

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

closes #24987 (closed)

Edited by Steve Xuereb

Merge request reports