Skip to content

Revert "Merge branch '4450-fix-container-wait' into 'master'"

What does this MR do?

Revert !1990 (merged) to fix gitlab#215037 (closed)

Why was this MR needed?

In https://gitlab.com/gitlab-org/gitlab-runner/-/blob/1494bf0071cb93ceb9bd771ea990ef292746f5d7/executors/docker/docker.go#L880 we check if the container is running or created. In the after_scripts it's neither because we reuse the build container that ran before_script+script so the container already exited. Since the container already exited we just return the previous exit code and never actually run the after_script. We reuse the build container because we don't want to create the same container again and recreate the state that container is in since it that can be slow.

Testing

Screen_Shot_2020-04-20_at_21.05.21

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

reference gitlab#215037 (closed)

Edited by Steve Xuereb

Merge request reports