Skip to content

Add goimports linter rule

Steve Xuereb requested to merge add-goimport-rules into master

What does this MR do?

Add goimport rule so that anything under gitlab.com/gitlab-org/gitlab-runner is in it's own import group. This is similar as if we are running goimports --local gitlab.com/gitlab-org/gitlab-runner

Why was this MR needed?

We often have this a comment in the merge request reviews that anything under gitlab.com/gitlab-org/gitlab-runner should be under it's own package. Instead of commenting on it every time make it part of the listing rules.

Every time something is not sorted as expected we see:

Screen_Shot_2020-04-15_at_13.04.00

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Edited by Steve Xuereb

Merge request reports