Skip to content

Clean Temporary Directories created by the Custom Executor

Mark McGuire requested to merge TronPaul/gitlab-runner:cleanup-custom-exec-tmp into master

What does this MR do?

This cleans up temporary directories created by the Custom Executor at cleanup time.

Why was this MR needed?

The Custom Executor leaves dangling temporary directories. From io/ioutil.TempDir:

It is the caller's responsibility to remove the directory when no longer needed.

Are there points in the code the reviewer needs to double check?

I did not try to DRY up the call to os.RemoveAll since I wasn't sure what the preferred way of doing that would be and don't have strong opinions on how since I have not developed in go before.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#25219

Merge request reports