Skip to content

Refactor BuildSection

Lyubomir Raykov requested to merge refactor-build-section into master

What does this MR do?

Refactors BuildSection to comply with our style guidelines and remove duplicate header printing logic:

  • section header logic is moved inside BuildSection
  • constants are on top
  • reordering functions

Why was this MR needed?

Are there points in the code the reviewer needs to double check?

Note for reviewer: it used to use logger.Println() which would go to debug output in the runner process and in job stdout (if I'm reading the BuildLogger correctly). Now it's using only SendRawLog, which means that it would only appear in the job trace.

It feels like this is not a loss, but if the reviewer thinks otherwise, I'll add Println to the logger interface.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Edited by Lyubomir Raykov

Merge request reports