Skip to content

Convert project unique name to RFC1123/RFC1035 standard

Fábio Matavelli requested to merge fabiomatavelli/gitlab-runner:fix-project-unique-name-non-rfc1123 into master

What does this MR do?

Converts the project unique name (runner-xxxxxx-project-00000000-concurrent-0) to RFC1123 standard.

Why was this MR needed?

As mention in #6325 (closed), #4779 (closed), #4277 (closed) and #3021 (closed) if the runner token has an underscore, which is the second part of the project unique name, it fails jobs that need the build container name to be RFC1123/RFC1035 compatible.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Closes #6325 (closed) Closes #4779 (closed) Closes #4277 (closed) Closes #3021 (closed)

Edited by Fábio Matavelli

Merge request reports