Remove backported os.Expand() implementation

What does this MR do?

Remove backported os.Expand() implementation originally made in !1677 (merged).

Why was this MR needed?

This is related to #4915 (closed)

Are there points in the code the reviewer needs to double check?

Maybe tests

Does this MR meet the acceptance criteria?

• Documentation created/updated
• Added tests for this feature/bug
• In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Closes #4915 (closed)

added Community contribution label

added [Deprecated] Category:Runner devopsverify grouprunner labels

added 1st contribution label

@erushton could you assign this to a reviewer?

/label ReviewP3

assigned to @pedropombeiro

Thanks a lot for your contribution @fabiomatavelli!

Everything looks OK to me, the only concern I'd have is documentation, but as far as I can tell the relevant section is already mentioning the correct behavior.

approved this merge request

assigned to @steveazz and unassigned @pedropombeiro

changed milestone to %13.0

mentioned in issue #6622 (closed)

approved this merge request

@fabiomatavelli would you mind if you rebase on master and resolve the conflicts If you get any issues whilst doing so, ping me and I'll help out

added 91 commits

• 0280215f...a5dd7c0a - 90 commits from branch gitlab-org:master
• 292982af - remove backported os.Expand() implementation

Compare with previous version

added 72 commits

• 6a28a877 - Use chocolatey for install software in Vagrant boxes
• ceadfc71 - Improve fpm detection
• a8bfccaf - Use $(MAKE) instead of make
• 8da2a130 - Package arm64 and aarch64 .deb and .rpm
• 476232c9 - Add trigering of GitLab Runner UBI images pipeline
• 629855d2 - Prevent building mips and s390x architectures
• 104bf8ab - Update docs/executors/custom_examples/libvirt.md
• f10d8666 - add support for per-job Docker network creation
• 412dfafa - Interactive Web terminal does not work on Windows
• 1de5fb8a - List which executors are at risk of having Runner token & other project code stolen
• de132ecc - Work around security warning regarding password
• 7fbcf918 - Add execution stage name in job trace
• 430b683c - Bump minio to latest version
• f95ded79 - overwite resource limits and requests
• 4d839d76 - Fix typo in release process docs
• 914cb601 - Add fedora 30 to supported OS
• 09085fdd - Improve message in Windows version detection
• 2f4d9357 - Address MR review comments
• ce4cf995 - Address MR review comments
• b3c4c268 - Address review comments
• 6bf7bf38 - Fix 'make all' target
• 579e4f20 - Update docs for Windows services
• f08765c1 - Allow service alias from config in Kubernetes executor
• d745d354 - Fix docker executor tests after changing Service struct
• 4477b97e - Apply suggestion to docs/executors/kubernetes.md
• 0fa4977b - Apply suggestion to docs/executors/kubernetes.md
• 01e51209 - Implement MR suggestions
• 36b301e6 - Improve `Code format` instructions in the process documentation
• 3ff637ea - Document Windows supported versions
• ab1e2f39 - Remove executor_ prefix from files in the executors package
• a0ee020c - Retry kubernetes commands when "error dialing backend: EOF" error is hit
• cabfac3c - Replace changelog entries generation script
• acc0a5ff - Update formatting of CHANGELOG.md
• d3e09bb5 - Retry kubernetes commands when "error dialing backend: EOF" error is hit
• d6745917 - fix an typo
• 6dc14c35 - Refactor and comment helpers/container/services.SplitNameAndVersion
• bbcba9d9 - Apply suggestion to helpers/container/services/services.go
• f34df04e - Applied MR suggestions
• eafd697d - Change title to include EC2
• 66afd6f0 - Include EC2 in Autoscaling on AWS link
• 3e3f885d - Update CHANGELOG for v12.9.0-rc1
• 9533985e - Bump version to 12.10.0
• 33029a20 - Add documentation about follow-up label
• e23276f8 - Switch to newer docs lint image for docs linting
• 3664fe18 - Fix docker machine executor test filename
• 62d00ddf - Quote bash arguments to avoid globbing
• 383b78db - Improve the wording of job output section titles
• 0f027663 - Update service documentation with correct toml
• 9e289595 - Mark fedora/29 as deprecated inside of docs
• 13caace2 - Update cron syntax to account for minutes
• 46bf7036 - Apply suggestion to docs/configuration/autoscale.md
• 7683532a - Remove deprecation notice for service commands
• 46bc8617 - Don't return err on disconnectNetwork in docker executor
• 8d4e2bc3 - Kubernetes executor execute commands with attach
• e3370e84 - Don't use the `function` keyword for the shell trap function since it's not...
• 0463bafb - Rename the trap shell function to `runner_script_trap`
• 3a0681d1 - Add CommandTerminatedError.Is implementation to exit the build properly
• c9c13b80 - Improve kubernetes tests
• cfdbbdbd - Print to job output Kubernetes script execution strategy
• 51596a98 - Remove Return call on Cleanup mock
• 1ec1022c - Add Vale checks to project
• a7ba6cb4 - Add a note for running within a Docker Container
• c17edf1f - Add note and link for session server, and install instructions.
• 0b72e322 - Apply suggestion to docs/install/docker.md
• 300489ff - Apply suggestion to docs/install/docker.md
• 90ab4eb1 - Apply suggestion to docs/configuration/advanced-configuration.md
• 7edea6dc - Session Server Docs Lint
• af105a6b - Upgrade Docker client version in CI to 19.03.5
• b58429b7 - Add comments for go tools
• d8c573f1 - Apply goimports fixes
• 32ed40cd - Install PowerShell Core for Windows dev env
• 85c55b89 - remove backported os.Expand() implementation

Compare with previous version

added 1 commit

• 050b4139 - remove backported os.Expand() implementation

Compare with previous version

added 119 commits

• 050b4139...a5dd7c0a - 118 commits from branch gitlab-org:master
• b218bd35 - Merge branch 'master' into 'remove-backported-expand-implementation'

Compare with previous version

changed the description

added 1 commit

• 0fa33ddf - remove entry from codeclimate

Compare with previous version

resolved all threads