Skip to content

Refactor order of methods for prepareHostAlias

Steve Xuereb requested to merge reorder-method-calls into master

What does this MR do?

Refactor order of methods for prepareHostAlias

Why was this MR needed?

We try to keep a consistent order of the codebase, where a method is put after the caller of the method.

In this case we have setupBuildPod which calls to methods prepareHostAlias, preparePodConfig and makePodProxyServices so the order should be like the following:

  • setupBuildPod
    • prepareHostAlias
    • preparePodConfig
      • Any other method that preparePodConfig calls
    • makePodProxyServices

Think of it as reading a book where you have 1 entry point and then you can follow the trail of the full method.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Merge request reports