Add gitlab-runner-helper binaries to S3 release
What does this MR do?
Adds the gitlab-runner-helper
binaries to the S3 release.
Why was this MR needed?
Another requirement for https://gitlab.com/gitlab-org/gitlab-runner/issues/6293
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
-
Documentation created/updated -
Added tests for this feature/bug -
In case of conflicts with master
- branch was rebased
What are the relevant issue numbers?
Part of https://gitlab.com/gitlab-org/gitlab-runner/issues/6293
Merge request reports
Activity
changed milestone to %12.8
added 1 commit
- dedaa2d8 - Add gitlab-runner-helper binaries to S3 release
@tmaczukin thanks for adding this, shouldn't all the commands for the helper image be available under the
gitlab-runner
binary? If we need it for docker images, do we already publish the docker images as tar which you can then rundocker import
why do we need the command itself ?After talking to @tmaczukin on slack he explained to me that we need
gitlab-runner-helper
so that the helper images can be built based on the ubi images so this would allow us to do something similar to https://gitlab.com/gitlab-org/gitlab-runner/-/blob/2f64143eee82715e3215805b8d00a4dc75e0ef3f/dockerfiles/build/Dockerfile.x86_64#L12
assigned to @tmaczukin and unassigned @steveazz
assigned to @steveazz and unassigned @tmaczukin
LGTM @tmaczukin thank you so much for being quick on this added to the merge train
mentioned in commit 31e27ad8