Skip to content

Prevent an invalid label from being added to pod

Sean Smith requested to merge wwsean08/gitlab-runner:issue/4565 into main

What does this MR do?

This causes the runner to manipulate label values that would be applied to the pod in kubernetes to prevent invalid characters from being introduced causing the CI job to fail

Why was this MR needed?

If an invalid character is in the label, that will cause the pod to fail to start meaning the CI job will fail.

Are there points in the code the reviewer needs to double check?

this doesn't fix the key being invalid, however that is set in the config.toml file as opposed to the label values which could be environment variables that are expanded and could have unexpected values

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#4565 (closed)

Edited by Sean Smith

Merge request reports