Create gitlab-runner home without skeletons files
What does this MR do?
gitlab-runner user is a technical user and for that reason should not contain bash profile scripts.
Why was this MR needed?
Are there points in the code the reviewer needs to double check?
gitlab-runner is a technical user. For that reason, it should never have had profile scripts in the first place.
useradd(from shadow-utils) supports to
--skel /dev/nullin at least
centos:6, etc. It's actually used since at least 2005: http://www.linuxfromscratch.org/lfs/downloads/6.1.1/
You can even find more references to
Concerning MR 1523, I really don't see why installation of the gitlab-runner should require a envvar (such as
GITLAB_RUNNER_DISABLE_SKEL=true sudo apt-get install -y gitlab-runner. For one, the default behavior should be the opposite if we were to use a envvar.
Does this MR meet the acceptance criteria?
- Documentation created/updated
- Added tests for this feature/bug
In case of conflicts with
master- branch was rebased