Skip to content

Add support for custom docker labels in Docker config

Pedro Pombeiro requested to merge (removed):4580-custom-docker-labels into master

What does this MR do?

This MR adds support for specifying custom Docker labels that can contain the values of environment variables.

Why was this MR needed?

In order to provide better logging, monitoring of jobs running, expanding on the basic set of labels would be helpful.

Are there points in the code the reviewer needs to double check?

I'm not sure if we should add both sets of labels (from Config.Docker.ImageLabels and from Build.Runner.Docker.ImageLabels) or just from Build.Runner.Docker.ImageLabels.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Closes #4580 (closed)

Edited by Pedro Pombeiro

Merge request reports