Reorder methods and add some more logging to RunCommand
What does this MR do?
Refactors RunCommand to reflect execution flow in the ordering of the methods. Additionally it updates some logging and adds a huge amount of comments to describe how RunCommand is working in details.
Why was this MR needed?
To make it little more clear how the execution of gitlab-runner run is happening. Full and clear understanding of it is required to resolve problems like #4173 (closed) and to design how graceful shutdown should be handled on Windows platform (#4917 (closed)).
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
-
Documentation created/updated -
Added tests for this feature/bug -
In case of conflicts with master- branch was rebased
What are the relevant issue numbers?
Edited by Steve Xuereb