Skip to content

Fix regex for finding virtualbox snapshot name and add tests

Elliot Rushton requested to merge fix-windows-vbox-snapshot-regex into master

What does this MR do?

Fixes #3274 (closed) - which the snapshot naming for VirtualBox wasn't handled well on Windows due to the \r\n way that Windows systems outputs for new lines.

Why was this MR needed?

Because a lot of people are experiencing weird behaviour on Windows.

Are there points in the code the reviewer needs to double check?

I checked all other regex's being used for newline handling and think I caught them all but it would be good to double check.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#3274 (closed)

Edited by Elliot Rushton

Merge request reports