Use time.Round from Go stdlib for web terminal (!1631) · Merge requests · GitLab.org / gitlab-runner · GitLab

The 17.0 major release is coming on May 16, 2024! This version brings many exciting improvements to GitLab, but also removes some deprecated features. We are introducing three breaking change windows during which we expect breaking changes to be deployed to GitLab.com. You can read more about it on our blogpost . The third breaking change window begins 2024-05-06 09:00 UTC and ends 2024-05-08 22:00 UTC.

Steve Xuereb requested to merge 3876-remove-time-duration-round-from-runner-code into master Oct 14, 2019

What does this MR do?

Use time.Round from Go stdlib for web terminal

Why was this MR needed?

We use a Go version that has Round and there is no need for roundDuration anymore is it was a copy/paste from the source code of Go.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

Documentation created/updated
Added tests for this feature/bug
In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Closes #3876 (closed)