Skip to content

WIP: Extend runner support for simplified dash shell

Chris Hoge requested to merge hogepodge/gitlab-runner:support-dash-shell into master

What does this MR do?

This merge request allows for non-bash shells to be used by the runner.

Why was this MR needed?

Some hosted container environments restrict shell.

Are there points in the code the reviewer needs to double check?

The code generates shells script that is executed inside of a container. Rather than using WriteString with multiple lines it would be more maintainable, testable, and readable to use a standalone string or file.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#1550

Merge request reports