Skip to content

Add trace entry for Docker authConfig resolving

Cody West requested to merge codyw-authconfig-trace into master

What does this MR do?

This MR adds a trace entry, indicating which method was used to get credentials, to the getAuthConfig function for the Docker executor.

Why was this MR needed?

To help diagnose authentication issues when pulling in Docker images. In some cases, it's unclear that somebody else at an organization might have ran docker login directly on a runner or provided an environment variable with auth configuration.

Are there points in the code the reviewer needs to double check?

There's really only the one method that got updated. But I'd say double-check all of it since it's my first contribution to the runner 😁.

I tested both docker config.json auth, as well as job payload auth. As far as I know things are working as expected.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Edited by Tomasz Maczukin

Merge request reports