Skip to content

Fix artifact uploading for Windows Docker containers

What does this MR do?

Fix for #4291 (closed) It ensures that the complete Powershell script is executed.

Why was this MR needed?

Artifacts and Cache are not working with Windows Docker executors.

Are there points in the code the reviewer needs to double check?

In addition to the script-blocks for uploading/downloading artifacts and cache there might be other code blocks which have not been executed previously and are now executed due to this change (e.g. when fetching the repository, the last step is git lfs pull. Without the empty line at the end, this was not executed. Now that it is executed it causes a container-crash on my Windows 10/1803 but it causes no problems on Windows 10 Server 1809. It works without problems in my Windows 10/1803 if git lfs pull is replaced with git-lfs pull. I did not add any code-change to fix this with this issue - might be solved with another issue)

Does this MR meet the acceptance criteria?

  • Documentation created/updated: no documentation affected
  • Added tests for this feature/bug: no
  • In case of conflicts with master - branch was rebased: no conflits

What are the relevant issue numbers?

#4291 (closed)

Edited by Steve Xuereb

Merge request reports