Skip to content

WIP: Vault PoC: Reading secrets

Tomasz Maczukin requested to merge vault-poc/reading-secrets into vault-poc/vault-client-and-authentication

What does this MR do?

Implements secrets reading from Vault and transition to job variables.

Why was this MR needed?

The whole goal of integration with Vault is to get the secrets and make them available for the job. So this MR does the thing 😉

Are there points in the code the reviewer needs to double check?

⚠ Built on top of !1397 (closed) ⚠

After merging the base MR, remember about changing the target branch to master!

Only then resolve the wip status:

  • merge !1397 (closed)
  • change target branch of this MR to master
  • resolve wip status
  • merge this MR

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Part of gitlab-org/gitlab-ee#9981

Edited by Tomasz Maczukin

Merge request reports