Fix case sensitivity for windows volumes (!1389) · Merge requests · GitLab.org / gitlab-runner

Steve Xuereb requested to merge 4294-make-windows-volume-case-insensitive into master May 29, 2019

What does this MR do?

Fix case sensitivity for windows volumes

Why was this MR needed?

In !1381 (merged) we removed the strings.ToLower for volumes for both Windows & Linux, since Linux is case-sensitive. Windows is not case-sensitive and even Docker follows this in https://github.com/moby/moby/blob/b1239f0a9f5acb08436d7c97092b3e0f5e75fcaa/volume/mounts/windows_parser.go#L82-L94 so it's wise to follow the same thing only for Windows.

C:\builds should be considered a valid volume but it's not in this case.

Also, update default build/cache dir for windows. For every volume spec we are doing strings.ToLower so it's nice for it to be consistent through the code.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

Documentation created/updated
Added tests for this feature/bug
In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Closes #4294 (closed)