Skip to content

Accept docker-windows as an option on register

Steve Xuereb - Out of Office Back 2024-06-16 requested to merge 4182-ask-for-docker-windows-in-registration into master

What does this MR do?

Accept docker-windows as an option on register

Why was this MR needed?

docker-windows is a valid executor which is not being accepted when a a user runs gitlab-runner register.

The cache path is still /cache after registering. This will be solved in #3915 (closed).

The docker-windows will only be viewable when using the Windows binary because the list is being generated from the registers executor https://gitlab.com/gitlab-org/gitlab-runner/blob/0634e6a5182f7c54b8849d76a2521bcc8a55b54e/commands/register.go#L86-102, and docker-windows is the only available for the Windows binary. This is good since we don't support docker-windows on Linux talking to a Windows docker daemon with this we make it clear as well.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Closes #4182 (closed)

Merge request reports