Skip to content

Set EFS flag to indicate that filenames and comments are UTF-8 encoded

Kazunori Yamamoto requested to merge kaz.yamamoto/gitlab-runner:set-efs-flag-for-zip-archive into master

What does this MR do?

Set EFS flag in Zip header of the artifacts to indicate that filenames and comments are UTF-8 encoded.

Why was this MR needed?

File paths consist of non-ascii characters (Japanese in my case) in build artifacts are garbled when unzipped by Windows built-in unarchiver.

Are there points in the code the reviewer needs to double check?

Additional test codes are just checking that non-ascii characters are not garbled by zip and unzip in the same docker container.
Is unzipping test on Windows required? (If so, how to achieve it?)

Does this MR meet the acceptance criteria?

  • Documentation created/updated
    • No update seems to be required
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#4176

Merge request reports