Extract unsupportedOSTypeError to errors pkg
What does this MR do?
Extract unsupportedOSTypeError to errors pkg
Why was this MR needed?
This error is going to be used in multiple places, for example:
- https://gitlab.com/gitlab-org/gitlab-runner/blob/6ce02c07cecf28401f767c916b2f9ce25c088d70/helpers/docker/helperimage/info.go#L32
- https://gitlab.com/gitlab-org/gitlab-runner/blob/b517b63923140f7d80cca40ee50bd23ba0009d9d/executors/docker/defaults.go#L29 from !1296 (merged)
- https://gitlab.com/gitlab-org/gitlab-runner/blob/03c9b2e7a4a408ea8ae9842076d82766bb987b7f/helpers/docker/volumes/parser/parser.go from !1269 (merged)
- https://gitlab.com/gitlab-org/gitlab-runner/blob/03c9b2e7a4a408ea8ae9842076d82766bb987b7f/helpers/docker/volumes/parser/parser_test.go from !1269 (merged)
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
-
Documentation created/updated -
Added tests for this feature/bug -
In case of conflicts with master- branch was rebased