Skip to content

Update docker executor Executor Options initialization

Steve Xuereb requested to merge 3896-initialize-docker-executor-depending-on-os into master

What does this MR do?

Update docker executor Executor Options initialization

Why was this MR needed?

Check the OSType after connecting to Docker and update the executor.ExecutorOptions depending on OSType used by Docker.

All of the implementations are done in defaults.go because of the interface is small enough and I don't think it required a file of each OSType we want to support.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • [-] Documentation created/updated
  • Added tests for this feature/bug
  • [-] In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

reference #3896 (closed)

Edited by Steve Xuereb

Merge request reports