Skip to content

Update Dockerfile for ubuntu image. Avoid `apt-get upgrade -y`.

Carlo Mion requested to merge mion00/gitlab-ci-multi-runner:patch-2 into master

What does this MR do?

Modify the Dockerfile for building the Ubuntu image. Removed the apt-get upgrade line, as it is not encouraged in a Dockerfile, as suggested by Docker itself.

Here is the relevant part:

Avoid RUN apt-get upgrade and dist-upgrade, as many of the “essential” packages from the parent images cannot upgrade inside an unprivileged container. If a package contained in the parent image is out-of-date, contact its maintainers. If you know there is a particular package, foo, that needs to be updated, use apt-get install -y foo to update automatically.

Why was this MR needed?

I think the modification I made follows the best practices suggested by Docker.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Merge request reports

Loading