Debug server refactorization
What does this MR do?
Moves out the Debug Server main implementation from the internals of
Why was this MR needed?
With !1242 (merged) we've restored
pprof integration that was removed by mistake when we were working on CI Web Terminal initial support (!934 (merged)). The regression was unnoticed until someone needed to use
This obviously suggested that we should start testing this part of the code. However, testing the commands is not an easy and reliable task. I was also thinking from a long time about separating Debug Server implementation from the
RunCommand is implementing too many things at once.
So with this MR I'm proposing a refactorization that moves the implementation of Debug Server to it's own package and additionally it adds tests that are covering most of the new code.
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
- Documentation created/updated
- Added tests for this feature/bug
In case of conflicts with
master- branch was rebased
What are the relevant issue numbers?