Move variables defining .gopath to a shared place for all Windows jobs
What does this MR do?
It makes the variables defining .gopath for Windows related jobs shared, so the information is used for all of them.
Why was this MR needed?
There is a problem with directory deletion when there is a symlink inside of the .gopath. Normally the symlink should be removed with after_script. But there are cases (manual cancel, timeout etc.) when the job execution is terminated in the middle, so it doesn't run the cleanup line.
We've added the pre_clone_script configuration on both Windows machines, but to work they need to know the value of $PKG_BUILD_DIR variable, even if .gopath is not used in a particular job. This MR adds the missing information.
Are there points in the code the reviewer needs to double check?
Does this MR meet the acceptance criteria?
-
Documentation created/updated -
Added tests for this feature/bug -
In case of conflicts with master- branch was rebased