Skip to content

WIP: Mount user volumes to services

Mathieu Parent requested to merge sathieu/gitlab-runner:mount-user-volumes-to-services into master

What does this MR do?

🔥 Please do not merge ! 🚒 I prefer !1139 (closed) to be merged instead.

NB : This is !663 (closed) on top of !1234 (closed), to show that it changes behavior.

Why was this MR needed?

(from !663 (closed)):

When docker executor is used, and we do use permament volumes = ["/cache:/cache", "/builds:/builds"].

Then, if using docker:dind we cannot access /builds folder, as it is not mounted to the service container.

This changes the order of operation to make this possible.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Edited by Mathieu Parent

Merge request reports