Skip to content

Do not display "Could not create cache adapter" error when no cache adapter is configured

Romain Tartière requested to merge smortex/gitlab-runner:fix-3802 into master

What does this MR do?

#3802 (closed) report misleading error messages when no cache is setup. This MR intend to silence these irelevent messages.

Why was this MR needed?

Each build produce an error message in the system logs. If you do not reject these messages on their content, they will flow to the OPS team which do not like them and create merge requests 😎

[31;1mERROR: Could not create cache adapter             [0;m  [31;1merror[0;m=cache factory not found: factory for cache adapter "" was not registered

Are there points in the code the reviewer needs to double check?

I don't do go, and was not able to run the tests on my machine. I hope the CI will help to some extend.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#3802 (closed)

Edited by Georgi N. Georgiev

Merge request reports