Skip to content

Refactor Docker auth config code (prerequisite to address #2673)

Patrick Decat requested to merge pdecat-forks/gitlab/gitlab-runner:refactor-docker-auth-config into master

What does this MR do?

This MR refactors the Docker auth config discovery code.

Why was this MR needed?

This MR is a prerequisite to resolve #2673 (closed) while satisfying comments made in a previous MR: !652 (diffs, comment 128627785)

Are there points in the code the reviewer needs to double check?

This refactoring is not supposed to add or remove any functionality. This is done in a separate MR to hopefully make it easier to review and test: !1176 (closed)

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Edited by Patrick Decat

Merge request reports