Update Docker client SDK
requested to merge 3488-update-supported-docker-api-in-gitlab-runner-to-follow-docker-guidance into master
What does this MR do?
Update docker client
Why was this MR needed?
We are using an old version of the client and where some features are not supported such as docker for windows
Are there points in the code the reviewer needs to double check?
- A successful pipeline running with
1.24
as a default version - Docker cli configfile changed but has no breaking changes
To Do
-
c1ebd90a move it to it's own MR (if possible)Safer to just have it in this MR -
Remove the override of golang.org/x/sys
to it's own MR -
Update offical docker client -
Check if we can move to context
package isntead ofgolang.org/x/context
since docker client usescontext
package now (Consider doing in a seperate MR). -
Make docker API configurable with env variableMoving to a seperate MR
MRs to merge before this one
QA
Web terminal
Screen_Recording_2019-01-25_at_09.32.13
Docker in docker
.gitlab-ci.yml
image: docker:stable
variables:
DOCKER_HOST: tcp://docker:2375/
# When using dind, it's wise to use the overlayfs driver for
# improved performance.
DOCKER_DRIVER: overlay2
services:
- docker:dind
before_script:
- docker info
build:
stage: build
script:
- docker build -t my-docker-image .
- docker run my-docker-image
Does this MR meet the acceptance criteria?
-
Documentation created/updated -
Added tests for this feature/bug -
In case of conflicts with master
- branch was rebased
What are the relevant issue numbers?
Edited by Steve Xuereb