Skip to content

Issue 2620 support for wildcard paths

What does this MR do?

It replaces the use of filepath.Glob() with doublestar.Glob() to add support for ** in any place where the file archiver is used (for example when globbing artifacts).

Why was this MR needed?

To address #2620 (closed) and make it possible to upload artifacts or cache dependencies without knowing ahead of the time the precise folder layout or build output.

Are there points in the code the reviewer needs to double check?

While tests pass and that should be sufficient to consider the MR it might be worth adding more tests to expose additional capabilities added by the doublestar.Glob() implementation. If that's done some sort of documentation updates would also then be appropriate.

Does this MR meet the acceptance criteria?

  • Documentation created/updated <-- see above
  • Added tests for this feature/bug <-- see above
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#2620 (closed)

Edited by ja11sop

Merge request reports