Skip to content

fix(parallels): use the newer sntp command to time sync

Max Wittig requested to merge max-wittig/gitlab-runner:fix/mac-parallels into master

I'm very much open to code improvements, as I'm not that experienced in Go, yet.

What does this MR do?

It addresses the issue #3666 (closed), which causes the parallels executor to fail on macOS >= 11.14.

In macOS < 11.14 the time sync was done using the ntpdate command, which was removed in 11.14 and replaced by sntp. This MR still supports both variants.

Additionally it allows the user to customize the time server. This is especially useful, when you cannot access time.apple.com (e.g. because of company proxy servers). In this case, you can specify your own NTP server without the need for a proxy instead.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

#3666 (closed)

Edited by Max Wittig

Merge request reports