Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gitlab-runner
gitlab-runner
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2,048
    • Issues 2,048
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 198
    • Merge Requests 198
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • gitlab-runnergitlab-runner
  • Merge Requests
  • !1123

Open
Opened Dec 27, 2018 by David Schile@bajacondorContributor0 of 3 tasks completed0/3 tasks
  • Report abuse
Report abuse

disallow service account overwrite when namespace overwrite is not supplied

  • Overview 4
  • Commits 4
  • Pipelines 4
  • Changes 4

What does this MR do?

When service account overwrite is requested by user, Make sure namespace overwrite has also been specified.

Why was this MR needed?

There is a security risk when users can specify a serviceaccount in the default CI namespace. Using a service account in the default namespace (such as the serviceaccount used to run the executor) could disrupt other teams using the default CI namespace.

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: gitlab-org/gitlab-runner!1123
Source branch: restrict-service-account-overwrite