Skip to content

WIP: Add support for pwsh.exe

Jason Yavorska requested to merge jlenny-pwsh into master

What does this MR do?

This adds support for pwsh.exe to the GitLab runner. The new PowerShell binary is selectable as 'pwsh'. For Hyper-V in docker-machine, it checks if both powershell.exe or pwsh.exe are available and prefers pwsh.exe if its there.

image

This includes updates to the vendor package for docker-machine since that project is in maintenance mode and not accepting new features.

Why was this MR needed?

Pwsh.exe is the new powershell.exe binary, though both will exist in production systems for some time.

Are there points in the code the reviewer needs to double check?

  • I'm probably not doing the vendored package update right.
  • This needs to be tested with HyperV; I don't have a setup for it.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Edited by Jason Yavorska

Merge request reports