Skip to content

Add timestamps to shell executors

Jason Yavorska requested to merge jlenny-timestamps into master

What does this MR do?

This MR adds timestamps to the notify, error, and warning messages output by the shell executors. Timestamps are bold-cyan, and printed in local system time.

bash

image

cmd

image

powershell

image

Why was this MR needed?

This does not completely solve but helps with issues like #2412 (moved)

Are there points in the code the reviewer needs to double check?

It's fairly straightforward but please ensure I've refactored the tests in a good way; that was my only doubt. The tests seemed over-fit since they are validating escaping but checking colors, but since they are testing

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased

What are the relevant issue numbers?

Edited by Jason Yavorska

Merge request reports