Skip to content

Kill session when build is cancelled

Steve Xuereb requested to merge 3637-terminal-session-not-killed-when-user-cancel-build into master

What does this MR do?

When the user cancels a build, we are not cleaning up the session server. Pass the build context and check for the Done and call session.Kill

Why was this MR needed?

For more context please read #3637 (closed)

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Added tests for this feature/bug
  • In case of conflicts with master - branch was rebased
  • Add screencast of it working

What are the relevant issue numbers?

Closes #3637 (closed)

Edited by Steve Xuereb

Merge request reports