Add network per build
What does this MR do?
Add support for per-job Docker network creation, based on !609 (closed), and built on top of !895 (closed) (rebased on master). By nature of its implementation it also provides a workaround fix for corporate DNS resolution as outlined in https://github.com/docker/libnetwork/issues/2187, and may mitigate issues such as #1541 (closed).
Why was this MR needed?
There is a huge need of proper service discovery b/w the job container and the service container(s). Use cases include:
- Running a selenium grid peer to the build container which can see the build container (i.e. karma tests).
- Set up complex interdependent application stacks.
Are there points in the code the reviewer needs to double check?
I am relying on claims made by the original author that it 'works', but didn't actually run it myself.
Does this MR meet the acceptance criteria?
-
Documentation created/updated -
Added tests for this feature/bug -
In case of conflicts with master
- branch was rebased
What are the relevant issue numbers?
Based off of !609 (closed) and !895 (closed).
Closes #1042 (closed)
Partial fix for #1541 (closed).
Merge request reports
Activity
mentioned in merge request !895 (closed)
added Community contribution devopsverify executordocker + 1 deleted label
added 43 commits
-
1e0f034d...18862634 - 39 commits from branch
gitlab-org:master
- 445b2e4b - add support for per-job Docker network creation
- dc2be4c4 - update documentation, fix formatting
- 6df5809a - add custom network mode per-build
- dd3f31d7 - General fixes for docker networking
Toggle commit list-
1e0f034d...18862634 - 39 commits from branch
assigned to @tmaczukin
added 6 commits
-
dd3f31d7...5b0bb5fc - 2 commits from branch
gitlab-org:master
- d44a79ba - add support for per-job Docker network creation
- ebf7e7de - update documentation, fix formatting
- 52854e56 - add custom network mode per-build
- 31974a6c - General fixes for docker networking
Toggle commit list-
dd3f31d7...5b0bb5fc - 2 commits from branch
added 6 commits
-
31974a6c...2de5b1a8 - 2 commits from branch
gitlab-org:master
- 9558a991 - add support for per-job Docker network creation
- c418d1d9 - update documentation, fix formatting
- 0fe57dfe - add custom network mode per-build
- 1313627b - General fixes for docker networking
Toggle commit list-
31974a6c...2de5b1a8 - 2 commits from branch
added 17 commits
-
1313627b...9ee08433 - 13 commits from branch
gitlab-org:master
- 87bc1e83 - add support for per-job Docker network creation
- 0e70cfea - update documentation, fix formatting
- 999d1e3d - add custom network mode per-build
- 359abfde - General fixes for docker networking
Toggle commit list-
1313627b...9ee08433 - 13 commits from branch
added 6 commits
-
359abfde...7443b5f4 - 2 commits from branch
gitlab-org:master
- 0964cb77 - add support for per-job Docker network creation
- 54546325 - update documentation, fix formatting
- 5617909a - add custom network mode per-build
- a8cd4eb6 - General fixes for docker networking
Toggle commit list-
359abfde...7443b5f4 - 2 commits from branch
Heya, @tmaczukin ? I don't mean to pester, but this MR has been open for 3 weeks now with no comments. Do you think you'll have some time soon to help me land it?
added 26 commits
-
a8cd4eb6...d31a4dc0 - 22 commits from branch
gitlab-org:master
- 6b642edf - add support for per-job Docker network creation
- 9d3703a1 - update documentation, fix formatting
- f006af81 - add custom network mode per-build
- d75f85ac - General fixes for docker networking
Toggle commit list-
a8cd4eb6...d31a4dc0 - 22 commits from branch
@tmaczukin any updates regarding this?